search

fli-iam / shanoir-ng

Shanoir (SHAring iN vivO Imaging Resources)
GNU General Public License v3.0
21 stars 21 forks source link

MS Datasets: MrProtocolStrategy finish implementation of coils #297

Open michaelkain opened 4 years ago

michaelkain commented 4 years ago

In Shanoir-old during the creation of the MrProtocol (for a serie during the import) a receivingCoil and a transmittingCoil are created in the database (in my tests with sh-old they have been null too, but to verify) and connected to the MrProtocol. In sh-ng coils are in another microservice, ms studies, this connection will have to be reestablished. Today the id remains null in MrProtocolStrategy. to be discussed with Elise and rested locally.

julien-louis commented 4 years ago

I assume that new coils will not be created every time a mrProtocol is created and that mrProtocol will be linked with existing coils when they already exist in the database. If I'm right, then the user should have to select the correct coils during the import or manually create new ones if they don't exist. One question is : can we automatically infer those coils given the data we have at that point : the dicom tag values and the user-selected aquisition equipment ? Another point : transmitting coil and receiving coil are among the fields that can be set via a studycard.

michaelkain commented 4 years ago

see issue #555, there remains some work with the coils to finish, the good point: no pressure, as the coil informations remain alive in the dicom files

michaelkain commented 3 years ago

Hi Julien, it would be great to close this issue. Could you please have a look? I think one problem is, that today coils are managed by ms studies, and not by ms datasets. One solution would be to migrate the management of coils into ms datasets (with the Angular UI). Choose an existing coil from the database if mapping is possible and create a new coil if nothing could be found in the database to have a complete mapping.

michaelkain commented 3 years ago

Problem: https://github.com/fli-iam/shanoir-ng/blob/develop/shanoir-ng-datasets/src/main/java/org/shanoir/ng/importer/strategies/protocol/MrProtocolStrategy.java lines 285-287 and 299-303 a new coil is created in memory, but never searched inside a db and never stored in any db.