search

flibbles / tw5-relink

Tiddlywiki5 plugin to better update all other tiddlers when renaming a tiddler.
https://flibbles.github.io/tw5-relink/
BSD 3-Clause "New" or "Revised" License
121 stars 6 forks source link

Error relinking a title with a path separator. #17

Closed joshuafontany closed 4 years ago

joshuafontany commented 4 years ago

I'm not 100% that is the root cause of this, but it mainly seems to happen when I have a path separator in the title and try to change it in any way (with or without the rename checkbox checked).

TW5.1.23-pre, running Node.js on Win10

The only other plugin I have loaded is: $:/plugins/wikilabs/uni-link

I am using $:/config/FileSystemPaths

Error screenshots attached.

Best, Josh F flibbles_relink_error01 flibbles_relink_error02

flibbles commented 4 years ago

Turns out this is a problem with how Relink and Uni-link interact with each other.

The problem was caused by me, but technically the fix is better done in Uni-link.

I've submitted and issue with them detailing what to do. If Mario (unilink creator) doesn't get a change out soon, I can make a workaround in Relink.

flibbles commented 4 years ago

(...seeing as how this is originally my fault for making a backward incompatible change)

joshuafontany commented 4 years ago

Mahalo (thanks)!

flibbles commented 4 years ago

Glad my fix works. Hopefully Mario will get that change in, so you won't have to have an overridden shadow tiddler. I'll leave this open in the meantime.

And Mario, if you're reading this. Sorry about putting this fix on you, seeing as how it was my change to my own code that broke stuff.

flibbles commented 4 years ago

I'm going to close this on my end, since there's nothing more that I can do. This problem will fix once the issue I submitted on Uni-Link is resolved.