flibbles / tw5-uglify

Compress TiddlyWiki5 javascript and plugins
Other
18 stars 2 forks source link

uglify breaks Editor toolbar button in 5.3.0 #9

Closed Hanl0n closed 1 year ago

Hanl0n commented 1 year ago

I uglified my Wiki and the Editor toolbar broke.

Error uglify

I can reproduce this with 5.3.0 empty.html on Firefox 115.0.1 and Chrome 114.0.5735.199 on Windows 11 Home 22H2. Just uglify any of my TiddlyWiki files or an empty.html and open a Tiddler.

flibbles commented 1 year ago

Are you using Uglify 1.6.1 which was released yesterday?

Hanl0n commented 1 year ago

I followed this link https://flibbles.github.io/tw5-uglify/uglified.html today. There is no version displayed but I a link to https://flibbles.github.io/tw5-uglify/ that states 1.6.1 .

flibbles commented 1 year ago

Found and isolated. I'll have it fixed later today, maybe tomorrow.

flibbles commented 1 year ago

Fixed in version v1.7.0.

Tiddlywiki made <$widget attribute=`substitution text` /> text a thing in V5.3.0, which means backticks had to now be treated specially. Uglify does so now.

Hanl0n commented 1 year ago

I tried it on Windows 11 with Firefox, Chrome and Edge. It is still broken in 1.7.0 and gives the same view when editing a tiddler.

flibbles commented 1 year ago

Are you sure? I know exactly what was causing the problem. In the shadow tiddler: $:/core/ui/EditorToolbar/mono-block, Uglify was stripping the quotes from around the "```" (triple back-tics), which was causing their new special handling to kick in inapropriately.

I've just confirmed in v1.7.0 demo site that that is not happening anymore, and I'm able to edit tiddlers just fine.

Are you certain you were using the latest version?

Hanl0n commented 1 year ago

I just tried again:

  1. I went to https://tiddlywiki.com/#Empty%20Edition and both
  2. clicked the green download button and
  3. followed the link to empty.html an saved the file.
  4. went to https://flibbles.github.io/tw5-uglify/uglified.html
  5. in both uglified.html I create a New Tiddler wit the +

and they are both broken.

flibbles commented 1 year ago

Oh nuts. I forgot to update the wizard. That's my bad.

(I forgot it existed. It's been so long since I've worked on Uglify.)

flibbles commented 1 year ago

Now it should work if you go through the wizard.

Hanl0n commented 1 year ago

Now it works with empty.html and my Wikis.

Thanks