Add dll path for windows in launch config json

flibitijibibo / RogueLegacy1

Rogue Legacy Source Code

https://cellardoorgames.com/roguelegacy/

Other

1.67k stars 147 forks source link

Add dll path for windows in launch config json #3

Closed antontsvil closed 5 days ago

antontsvil commented 5 days ago

Changes:

For easier setup in Windows environments, include an env variable for PATH rather than LD_LIBRARY_PATH which seems to be specific to Linux.

Legal Stuff:

By submitting this pull request, I confirm that...

[x] My changes may be used in a future commercial release of Rogue Legacy
[x] I will be credited in a CONTRIBUTORS file and the "GitHub Friends" section of the credits for all of said releases, but will NOT be compensated for these changes unless there is a prior written agreement

flibitijibibo commented 5 days ago

I don't recall the syntax but I think we can do both by adding an OS check - I'd have to look it up. Still, definitely okay with merging this if we can get both Linux and Windows build environments working at the same time.

antontsvil commented 5 days ago

ooh an OS check would be ideal. This line could also just as easily be added to the README until then.

Is the os check thing something you can do in launch json? I'm more familiar with intellij

flibitijibibo commented 5 days ago

According to SO it appears to just be "windows": and "linux": blocks:

https://stackoverflow.com/questions/54982502/how-to-target-platforms-with-launch-json

antontsvil commented 5 days ago

Easy enough - made the change and seems to work just fine! Have yet to double check it still works in linux though