Closed haiyingweng closed 4 years ago
SORRY THIS ENDED UP BEING A HUGE PR 😞 so take your time to review (it's mostly UI)
Setup list settings Moved calculation of users preview to the class Made a confirmation modal
🗒️ : I didn't integrate backend for actions in list settings bc this is already a huge PR, so I'll do that in another PR
ListSettingsVC
ConfirmationModalView
PrivacySwitch
Regular list settings vs default list settings
This recording was made before I added the Edit to collaboration cell 😅, reference the screenshot for how it looks with the Edit
Edit
SORRY THIS ENDED UP BEING A HUGE PR 😞 so take your time to review (it's mostly UI)
Overview
Setup list settings Moved calculation of users preview to the class Made a confirmation modal
🗒️ : I didn't integrate backend for actions in list settings bc this is already a huge PR, so I'll do that in another PR
Changes Made
ListSettingsVC
,ConfirmationModalView
, andPrivacySwitch
Related Issues
30 #43 #40
Screenshots/GIFs
Regular list settings vs default list settings
This recording was made before I added the
Edit
to collaboration cell 😅, reference the screenshot for how it looks with theEdit