flickr / flickr-sdk

Almost certainly the best Flickr API client in the world for node and the browser
https://www.flickr.com/services/api
MIT License
131 stars 29 forks source link

Parameter Request #128

Closed ebisbe closed 6 years ago

ebisbe commented 6 years ago

Can you add the Opt in opt out in this request https://www.flickr.com/services/api/flickr.people.getGroups.html ?

I find very annoying ( for me and for you ) having to do another request for each group I want to know if they are opted out. You could add it in the extras I'll be very happy about it.

ebisbe commented 6 years ago

@superic ?

superic commented 6 years ago

Do you mean to see if the user is opted out of the Groups beta?

ebisbe commented 6 years ago

Nope. Here flickr.groups.getInfo we can get the photo_limit_opt_out property of a group. To see if the group has opted out of the limit a photo can be shared to a group. I'd like to know if I can get that property in flickr.people.getGroups and flick.groups.search.

I'm implementing a GraphQl with Flickr and it's annoying needing to do 1 additional query for each group I get in any result just to get that parameter.

For what I see from the flickr website the GroupSearch has a lot of parameters that are added in the response but none of them are listed in the docs. In another issue you recommended me to try things because the docs are outdated so I've been trying but without any luck...

I don't think that kind of petition belongs to the Api Group in flickr because it's dead... But I'm not sure who I should ask to do it...

alex-seville commented 6 years ago

@ebisbe we don't index that setting in our search engine, so it can't be exposed via those APIs.

ebisbe commented 5 years ago

Hello @alex-seville, I don't want to open onther issue because it's realted to missing params from the queries.

Is the 'invitation_only' param from the Groups available somewhere? I've seen in the website that you use in the groups.getInfo and groups.Search some extra parameters but they don't work datecreate,date_activity,eighteenplus,invitation_only,needs_interstitial,non_members_privacy,pool_pending_count,privacy,member_pending_count,icon_urls,date_activity_detail,use_vespa,membership_info,has_pending_invite,secure_rules

ebisbe commented 5 years ago

@superic , @alex-seville can you help me? The flickr forums is not helping at all.

alex-seville commented 5 years ago

I suspect not, these group attributes that you are referencing are more associated with the Flickr product.

As an aside, you may want to check out the API TOS just to ensure that whatever you're building, and the way you're building it, are compliant: https://www.flickr.com/help/terms/api

ebisbe commented 5 years ago

@alex-seville I suspect that when you say that:

these groups attributes that you are referencing are more associated with the Flickr product

do you mean that they are private for Flickr use only. I think it's very confusing then having a public api call that let's you join a group and another to ask to join a 'invitation_only' group but not having a real way to know if a group is 'invitation_only'...

And as far as I know my product is API compliant but I don't think anyone will review it ever...