search

flickr / flickr-sdk

Almost certainly the best Flickr API client in the world for node and the browser
https://www.flickr.com/services/api
MIT License
131 stars 29 forks source link

Missing single quote in ts definition #160

Closed palamago closed 1 year ago

palamago commented 1 year ago

There is a missing single quote here: https://github.com/flickr/flickr-sdk/blob/main/script/build-types.ejs#L2 Issue added in 6.2

I'm having this issue in my build:

example-app:build: ../node_modules/flickr-sdk/flickr-sdk.d.ts:2:43
example-app:build: Type error: Unterminated string literal.
example-app:build:
example-app:build:   1 | import type { Request } from './lib/request';
example-app:build: > 2 | import type { Response } from 'superagent;
example-app:build:     |                                           ^
example-app:build:   3 | import type OAuth from './services/oauth';
example-app:build:   4 | import type Feeds from './services/feeds';
example-app:build:   5 | import type Upload from './services/upload';

Rollbacking to 6.1.2, latest working version in ts context.

jeremyruppel commented 1 year ago

Thanks for the report! This should be fixed in v6.2.1