flickr / yakbak

Record and playback HTTP responses
MIT License
1.06k stars 83 forks source link

Plans for using native Promises? #47

Open spurreiter opened 6 years ago

spurreiter commented 6 years ago

Hi Jeremy,

Do you have any plans to use native promises with your library? Greater node 8 they are pretty much faster then js implementations like bluebird.

Today we encountered a strange problem with bluebird which we could not nail down to a PoC. While recording a tape the response was not finally written to disk but the Promise already resolved, such require(file) returned an empty response resulting in a "TypeError tape is not a function". Removing bluebird from lib/buffer.js solved the issue for us. For the urgency we had to move forward, we created the fork at https://github.com/spurreiter/yakbak-native-promise which has bluebird replaced with native promises. Are you interested in a PR?