flier / pyfasthash

Python Non-cryptographic Hash Library
Apache License 2.0
281 stars 52 forks source link

0.9.3 segfaults on Python 3.8, master works fine #35

Closed piotr1212 closed 3 years ago

piotr1212 commented 5 years ago

With Python 3.8 beta2 on Fedora 30. When installing pyhash with pip, it segfaults during import. When installing the latest git master it works fine.

Seems that the last commit fixes this issue. Please create a new release and upload to pip.

(venv38) piotr@fedora ~/g/pyfasthash> pip install pyhash
Collecting pyhash
Installing collected packages: pyhash
Successfully installed pyhash-0.9.3
(venv38) piotr@fedora ~/g/pyfasthash> python -c 'import pyhash'
fish: “python -c 'import pyhash'” terminated by signal SIGSEGV (Address boundary error)
(venv38) piotr@fedora ~/g/pyfasthash> 
(venv38) piotr@fedora ~/g/pyfasthash> pip uninstall pyhash
Uninstalling pyhash-0.9.3:
  Would remove:
    /home/piotr/venv38/lib/python3.8/site-packages/_pyhash.cpython-38-x86_64-linux-gnu.so
    /home/piotr/venv38/lib/python3.8/site-packages/pyhash-0.9.3.dist-info/*
    /home/piotr/venv38/lib/python3.8/site-packages/pyhash/*
Proceed (y/n)? y
  Successfully uninstalled pyhash-0.9.3
(venv38) piotr@fedora ~/g/pyfasthash> pip install .
Processing /home/piotr/git/pyfasthash
Building wheels for collected packages: pyhash
  Building wheel for pyhash (setup.py) ... done
  Stored in directory: /tmp/pip-ephem-wheel-cache-0c99mp2n/wheels/cc/a5/b3/848741377da41f80903f4eccce209d11c91ca1cb7d3b891c75
Successfully built pyhash
Installing collected packages: pyhash
Successfully installed pyhash-0.9.3
(venv38) piotr@fedora ~/g/pyfasthash> python -c 'import pyhash'
(venv38) piotr@fedora ~/g/pyfasthash>