search

flier / tokio-kafka

Asynchronous Rust client for Apache Kafka
Apache License 2.0
31 stars 1 forks source link

Fix api versions #15

Closed polachok closed 6 years ago

polachok commented 6 years ago

1) Currently we choose the highest version supported by broker. This is incorrect, we don't support it in the client for most requests. 2) Using Request api version for parsing Message is also incorrect. It's absolutely possible to receive a Message v0 in response to FetchRequest v1.

This patch allows me to enable with_api_versions_request() on Consumer.

polachok commented 6 years ago

@flier ?

flier commented 6 years ago

agree, we need trace those supported ApiVersions base on our compatibility level