flightaware / dump978

FlightAware's 978MHz UAT demodulator
BSD 2-Clause "Simplified" License
40 stars 16 forks source link

Fix: Remove obsolete skyview978 conffiles #8

Closed wiedehopf closed 4 years ago

wiedehopf commented 4 years ago

Due to the apt process, the actual config file in conf-available is at least sometimes removed before lighty-disable-mod is called. This leads to lighty-disable-mod not working and lighttpd failing to start. To fix that problem, just delete the symlink in conf-enabled.

See also this forum thread with a user reporting that problem: https://discussions.flightaware.com/t/skyview-after-update-3-7-2-refused-to-connect/55011

wiedehopf commented 4 years ago

Just spotted that of course the obsolete statcache config file needs to be removed as well.

On a side note, this package might need a post-rm file as well like the one dump1090-fa has. (debian/dump1090-fa.postrm) This package should be changed to deleting the symlink directly as well, using lighty-disable-mod is just too unreliable. I've seen this cause problems before for people purging dump1090-fa instead of just removing it.

eric1tran commented 4 years ago

Thanks @wiedehopf. We will test this out.

wiedehopf commented 4 years ago

Note for people who already installed this is not going to fix it. (not sure why the user in the forum was even getting the test version)

So you'll have to change the version condition and maybe push another update to those testers. Good luck on releasing 3.7.2 !

mutability commented 4 years ago

No, we won't do an additional release to fix this, nobody should be on the -testing repository.

wiedehopf commented 4 years ago

I'm not too familiar with the debian package system, but maybe it's that Breaks line for piaware-release?

root@pi ~ # apt show piaware-release
Package: piaware-release
Version: 3.7.1
[...]
Breaks: piaware-repository-testing (<< 3.7.1)

Was the testing repository package installed on the UAT testing image for 3.7.0.1? Maybe he has one of those images.

mutability commented 4 years ago

No, it's not the Breaks line - that's a negative dependency (it means that piaware-release 3.7.1 cannot be installed at the same time as piaware-repository-testing << 3.7.1)

When one binary package declares that it breaks another, dpkg will refuse to allow the package which declares Breaks to be unpacked unless the broken package is deconfigured first, and it will refuse to allow the broken package to be reconfigured.

The testing repository has never been in any released image, AFAIK. (An earlier iteration of the list file for the testing repository was briefly, accidentally, included in the main repository package for quite an old version - 3.0.3 - we changed the URL in response. see flightaware/piaware-support@63bf9ce6aa64c42d7cd9919d451fb51e038aa1bc and flightaware/piaware-support@d71ffa99d307aae68bfc9eecf38c1b250fff9cbc)

mutability commented 4 years ago

Note also that that user is really the only install I see with this behaviour; I've looked through both actively-connected piawares (he is the only non-FA 3.7.2) and web requests to the testing repository URLs (over the last couple of days, it's only him and FA-originated requests). So whatever happened, it's unlikely to be anything in the standard images or, given the installed base of piaware images, we'd have seen other cases of it already. I'm pretty sure it's a case of the -testing repository being manually installed somehow. Maybe the info I requested on the forums will help track it down, but I'm pretty sure this is a singleton.