fix: insert "symbols" instead of `null` for deduped objects

flightcontrolhq / superjson

Safely serialize JavaScript expressions to a superset of JSON, which includes Dates, BigInts, and more.

https://www.flightcontrol.dev?ref=superjson

MIT License

4.01k stars 87 forks source link

fix: insert "symbols" instead of `null` for deduped objects #251

Open juliusmarminge opened 1 year ago

juliusmarminge commented 1 year ago

Resolves https://github.com/blitz-js/superjson/pull/247#discussion_r1263815919

Not sure how you wanna do regarding semver?

Skn0tt commented 1 year ago

Not sure how you wanna do regarding semver?

I don't regard the specific structure of the outputted JSON as being part of SuperJSON's API contract, so I don't think this would be a breaking change. I'd release this as a minor release.

Skn0tt commented 1 year ago

Excuse the late reply btw! My understanding is that this PR isn't urgent for your usecases, so I haven't prioritise this until now (I'm a bit under-water currently). If you need this more urgently, let me know and i'll try to prioritise it earlier.