flightlessmango / MangoHud

A Vulkan and OpenGL overlay for monitoring FPS, temperatures, CPU/GPU load and more. Discord: https://discordapp.com/invite/Gj5YmBb
MIT License
6.45k stars 287 forks source link

Uploading is Broken Unless the Game Already Has a User Benchmark (New Games Can't Upload Benchmarks) #1044

Open gardotd426 opened 1 year ago

gardotd426 commented 1 year ago

Describe the bug I posted this to flightlessmango/flightlessmango.com, but that issues thread seems to have been dead for well over a year now, and isn't being monitored/responeded to.

FlightlessMango.com is completely broken when it comes to uploading benchmarks for any new games that didn't already exist in the FlightlessMango.com database whenever it was last updated.

For example: Countless games that have released in the last year are incapable of getting benchmarks. Star Wars: Jedi Survivor for example. When you go to FlightlessMango.com, log in, and try to upload a benchmark, the game doesn't exist, so there's no way to upload a benchmark for it. You can ONLY upload benchmarks by clicking User Benchmarks -> Searching for the game you want to upload a benchmark for -> Clicking it -> Clicking "New Benchmark"

If the game doesn't exist and so you don't get any results when searching, you can't upload a benchmark.

Even using F5 to upload from in-game shows it's uploading:

[2023-05-29 05:34:32.275] [MANGOHUD] [info] [logging.cpp:67] /home/matt/JediSurvivor_2023-05-29_05-33-39_summary.csv % Total % Received % Xferd Average Speed Time Time Time Current Dload Upload Total Spent Left Speed 100 256k 0 103 100 256k 47 118k 0:00:02 0:00:02 --:--:-- 118k But there's nothing there (I looked under my username and at the "Latest User Benchmarks."

I know you haven't worked on this site in a long time, but it was INCREDIBLY useful and I used to brag on it constantly. Is this abandoned?

List relevant hardware/software information

To Reproduce Steps to reproduce the behavior:

  1. Go to FlightlessMango.com and login
  2. Attempt to upload a benchmark for any game released this year. Specifically I've tried Dead Space Remake and Star Wars Jedi Survivor
  3. See that there are no search results
  4. You can't upload a benchmark

Expected behavior The game's database is up to date.

Additional context If there are going to be no more updates to the website and it's impossible to upload new benchmarks, the MangoHud README should be updated to not say you can upload benchmarks to the site.

flightlessmango commented 1 year ago

Basically I've messed up the database a bit by rewriting the fetch method a few times. We need to settle on an api to fetch games and probably reset the database clearing all current logs and games

When you upload using mangohud it doesn't know your username or anything, it will upload anonymously and without an assigned game. it's not discoverable on the site mangohudtries to xdg-open the link, but I guess you don't have it or doesn't have a browser selected for xdg

gardotd426 commented 1 year ago

I do have xdg-open and my browser is set, I can easily open links from my terminal, it just never opens anything.

On Wed, Jun 21, 2023 at 6:55 AM flightlessmango @.***> wrote:

Basically I've messed up the database a bit by rewriting the fetch method a few times. We need to settle on an api to fetch games and probably reset the database clearing all current logs and games

When you upload using mangohud it doesn't know your username or anything, it will upload anonymously and without an assigned game. it's not discoverable on the site mangohudtries to xdg-open the link, but I guess you don't have it or doesn't have a browser selected for xdg

— Reply to this email directly, view it on GitHub https://github.com/flightlessmango/MangoHud/issues/1044#issuecomment-1600622226, or unsubscribe https://github.com/notifications/unsubscribe-auth/AM5Y333J5WK3FYCIB4WNKLDXMLHKXANCNFSM6AAAAAAZGUMN24 . You are receiving this because you authored the thread.Message ID: @.***>

flightlessmango commented 1 year ago

When I think about it, it's probably because xdg-open doesn't exist in the sniper runtime container. It's possible it works with sniper beta and a minor adjustment to mangohud

flightlessmango commented 1 year ago

Actually xdg-open appears to exist in the runtime at least on the beta. Works for me ™ https://flightlessmango.com/logs/4066

gardotd426 commented 1 year ago

Oh I'm sorry if I wasn't more clear, I'm not even using the Steam Runtime, I'm playing Jedi Survivor on EA App (I got my EA Play subscription way before EA came crawling back to Steam lol, so I play my EA games on the EA App).

What I'm confused by is the fact that when I'm running lutris in the terminal, I never see a link, just the uploading output. I could try doing it in Proton to see if it's a Wine issue, I've noticed SOME Wine games don't open links correctly with xdg-open, while other builds do (IIRC wine-ge often opens them correctly, but sometimes tkg doesn't, etc). I actually first noticed this while inside EA App and trying to open a link.

Surely there's an easy way in Python to have the log output print the URL it's trying to open with xdg-open so it could just be clicked on if xdg-open fails? I haven't had to write a line of Python in forever so I don't really remember/know how to do it or I'd try and write something up.

gardotd426 commented 1 year ago

Like:

[2023-05-29 05:34:32.275] [MANGOHUD] [info] [logging.cpp:67] /home/matt/JediSurvivor_2023-05-29_05-33-39_summary.csv
% Total % Received % Xferd Average Speed Time Time Time Current
Dload Upload Total Spent Left Speed
100 256k 0 103 100 256k 47 118k 0:00:02 0:00:02 --:--:-- 118k
Uploaded benchmark to https://flightlessmango.com/blahblahblah
gardotd426 commented 1 year ago

Ugh ignore the python comment, I was simultaneously helping someone debug lutris while typing that and so I had python on the brain. But yeah if there's a way to print the URL to stdout that'd be fantastic, and I'll try different wine builds to see if any of them auto-open the link with xdg-open for now.

flightlessmango commented 1 year ago

We print url now 12567c6