search

flightlessmango / MangoHud

A Vulkan and OpenGL overlay for monitoring FPS, temperatures, CPU/GPU load and more. Discord: https://discordapp.com/invite/Gj5YmBb
MIT License
6.47k stars 287 forks source link

ASUS Temperature not read #1222

Closed luisalvarado closed 8 months ago

luisalvarado commented 9 months ago

I did the whole bug report wrong here, sorry. Here is the original message from

https://github.com/flightlessmango/MangoHud/commit/d30cf162c15bfabfddd456ceb48a6d3848fa7098

Looks like after this update, on the Asus Z790 Hero the CPU Temp does not show anymore. It shows as 0 always. If I rollback to https://github.com/flightlessmango/MangoHud/commit/3cee6f15ded1b086333738e2388eb1d10dce9ba6 then it works correctly.

flightlessmango commented 9 months ago

I'm not sure why this changed caused an issue. I also have an asus z790 with the module nct6798 and it appears to work correctly

luisalvarado commented 9 months ago

@flightlessmango Okay let me provide the specs if it helps. I am on Ubuntu 23.10 with the following:

image

Running sensors shows this:

image

image

image

Is there anything else I can put here as info to provide more relevant data?

flightlessmango commented 9 months ago

Coretemp should already have been used for cpu temp, this change shouldn't have changed anything

luisalvarado commented 9 months ago

Coretemp should already have been used for cpu temp, this change shouldn't have changed anything

Apologies because I do not know what you want me to reply now. All I am reporting is, before the commit it showed, after it did not.

luisalvarado commented 9 months ago

I could do a video if that helps?

luisalvarado commented 9 months ago

@flightlessmango

Okay here is the video, I did a git hard on the commit and then the most recent commit to show you. Let me know if I did something wrong (Please wait like 15 minutes for the video to show properly)

https://www.youtube.com/watch?v=LuFixCwIwWU

Also noticed on the latest commit while doing the video that trying to reset the stats did not work. Every time I pressed Shift_r + F10 (I think it was F10) it showed the stats as 0 but then they went back to the previous values they had.

flightlessmango commented 9 months ago

Resetting fps metrics is F10 by default This commit should resolve the cpu temp issue fc54f48257e011a629487e2f4b965c90355d9c9d

luisalvarado commented 9 months ago

@flightlessmango Yes sir, the temperature is fixed!. Thank you a lot.

In regards to resetting the FPS Metrics, the only "issue" if we can call it that is the following behavior. Let us say we initialize a game and I have it like this setup in the beginning:

This is 5 seconds into the game

image

This is 20 seconds into the game

image

This is about 40 seconds into the game

image

As you can see between each image, the 1% and 0.1% were not updated till, I would guess, there was enough data to fill them in. Like it needed X amount of time to start showing data for them. This makes sense, since I would need more data to properly provide a 1% FPS stat and even more time to provide a 0.1% FPS stat. Up to this point everything is fine.

The problem is when I try to reset by pressing SHIFT + F10, every time I press it it sets all of them to 0 FPS, which is good, but then they go back to their original values. Here are two images one second apart:

image

image

It immediately starts filling in the 1% and 0.1% even though it needed more data before starting to show them.

If you like I can do another video to show it by pressing SHIFT + F10 multiple times?

luisalvarado commented 8 months ago

@flightlessmango Hi friend, did the above make sense. Do you feel it is okay or did I find an error with the resetting?

flightlessmango commented 8 months ago

This should resolve the issue 48d84262cd21ae3916e2d9713b9f1a223190b1a6. It should fill in the metrics right away now from the start and when resetting

luisalvarado commented 8 months ago

Apologies, just noticed this message. I am testing this out ASAP!