search

flightlessmango / MangoHud

A Vulkan and OpenGL overlay for monitoring FPS, temperatures, CPU/GPU load and more. Discord: https://discordapp.com/invite/Gj5YmBb
MIT License
6.33k stars 278 forks source link

Meson can't locate imgui_stdlib.cpp to compile the subproject after 0.7.1 release. #1226

Closed SpidFightFR closed 7 months ago

SpidFightFR commented 7 months ago

Describe the bug Building fails when compiling the version 0.7.1, as building imgui itself fails because of supposedly misc/cpp/imgui_stdlib.cpp is missing while being present.

List relevant hardware/software information

To Reproduce Steps to reproduce the behavior:

  1. Compile Mangohud
  2. the issue happens.

Expected behavior It should compile normally.

Logs

meson-logs ``` The Meson build system Version: 1.3.1 Source dir: /builddir/MangoHud-0.7.1 Build dir: /builddir/MangoHud-0.7.1/build Build type: native build Project name: MangoHud Project version: v0.7.1 C compiler for the host machine: cc (gcc 13.2.0 "cc (GCC) 13.2.0") C linker for the host machine: cc ld.bfd 2.41 C++ compiler for the host machine: g++ (gcc 13.2.0 "g++ (GCC) 13.2.0") C++ linker for the host machine: g++ ld.bfd 2.41 Host machine cpu family: x86_64 Host machine cpu: x86_64 Program python3 (mako) found: YES (/usr/bin/python3) modules: mako Checking if "GCC atomic builtins" compiles: YES Checking if "Supports timespec_get" compiles: YES Checking for function "bswap32" : YES Checking for function "bswap64" : YES Checking for function "clz" : YES Checking for function "clzll" : YES Checking for function "ctz" : YES Checking for function "expect" : YES Checking for function "ffs" : YES Checking for function "ffsll" : YES Checking for function "popcount" : YES Checking for function "popcountll" : YES Checking for function "unreachable" : YES Found pkg-config: YES (/usr/bin/pkg-config) 0.29.2 Run-time dependency x11 found: YES 1.8.7 Dependency wayland-client skipped: feature with_wayland disabled Run-time dependency dbus-1 found: YES 1.14.10 Run-time dependency threads found: YES Compiler for C supports arguments -Werror=implicit-function-declaration: YES Compiler for C supports arguments -Werror=missing-declarations: YES Compiler for C supports arguments -Werror=missing-prototypes: YES Compiler for C supports arguments -Werror=return-type: YES Compiler for C supports arguments -Werror=incompatible-pointer-types: YES Compiler for C supports arguments -Wno-unused-parameter: YES Compiler for C supports arguments -Qunused-arguments: NO Compiler for C supports arguments -fno-math-errno: YES Compiler for C supports arguments -fno-trapping-math: YES Compiler for C supports arguments -Wno-missing-field-initializers: YES Compiler for C++ supports arguments -Werror=missing-declarations: YES Compiler for C++ supports arguments -Werror=return-type: YES Compiler for C++ supports arguments -Wno-unused-parameter: YES Compiler for C++ supports arguments -Qunused-arguments: NO Compiler for C++ supports arguments -fno-math-errno: YES Compiler for C++ supports arguments -fno-trapping-math: YES Compiler for C++ supports arguments -Wno-non-virtual-dtor: YES Compiler for C++ supports arguments -Wno-missing-field-initializers: YES Checking for function "dlopen" : YES Checking for function "clock_gettime" : YES Executing subproject vulkan-headers vulkan-headers| Project name: vulkan-headers vulkan-headers| Project version: 1.2.158 vulkan-headers| C compiler for the host machine: cc (gcc 13.2.0 "cc (GCC) 13.2.0") vulkan-headers| C linker for the host machine: cc ld.bfd 2.41 vulkan-headers| Build targets in project: 1 vulkan-headers| Subproject vulkan-headers finished. Checking for size of "void*" : 8 Executing subproject imgui imgui| Project name: imgui imgui| Project version: 1.89.9 imgui| C++ compiler for the host machine: g++ (gcc 13.2.0 "g++ (GCC) 13.2.0") imgui| C++ linker for the host machine: g++ ld.bfd 2.41 subprojects/imgui-1.89.9/meson.build:14:10: ERROR: File misc/cpp/imgui_stdlib.cpp does not exist. A full log can be found at /builddir/MangoHud-0.7.1/build/meson-logs/meson-log.txt ```
flightlessmango commented 7 months ago

Error like this sometimes happen when you update the git repo but keep an old build directory

SpidFightFR commented 7 months ago

Error like this sometimes happen when you update the git repo but keep an old build directory

That's weird... For the explanation, the tool i used to compile is xbps-src, and basically it just takes the latest release tarball file provided on your github, it extracts it and compile it...

I made sure to clean the build directories and the repo, it can't be that. Isn't there a lib to include a dependency for meson or something like that ?

Edit: it's weird cuz in the tarball you provide, the same tarball xbps-src uses, the "missing" file is indeed present...

zlice commented 7 months ago

Flightless, what version of meson are you building with?

that's not the issue

https://github.com/flightlessmango/MangoHud/archive/refs/tags/v0.7.1.tar.gz

https://github.com/flightlessmango/MangoHud/releases/download/v0.7.1/MangoHud-v0.7.1-Source-DFSG.tar.xz

differ, the DFSG doesn't have imgui files like the directory 'misc'

flightlessmango commented 7 months ago

Uploaded new source files that should contain the misc folder

zlice commented 7 months ago

https://github.com/flightlessmango/MangoHud/releases/download/v0.7.1/MangoHud-v0.7.1-1-Source-DFSG.tar.xz looks like it works. Thanks!

SpidFightFR commented 7 months ago

Yep i tested as well and it works ! thanks for your help Flightless! :smile: