search

flightlessmango / MangoHud

A Vulkan and OpenGL overlay for monitoring FPS, temperatures, CPU/GPU load and more. Discord: https://discordapp.com/invite/Gj5YmBb
MIT License
6.13k stars 262 forks source link

Minecraft crashes on logging hotkey #1289

Closed holybaechu closed 3 months ago

holybaechu commented 3 months ago

Describe the bug When I press logging hotkey(I set it to Shift_L+F4), It crashes the game

List relevant hardware/software information

To Reproduce Steps to reproduce the behavior:

  1. Install Minecraft 1.19.2 with Java 17/21 in Prism Launcher
  2. Enable MangoHud option in Prism Launcher settings
  3. Play Minecraft
  4. Hit logging hotkey you have set to
  5. Crashes

Expected behavior Should start logging the game

Screenshots No screenshot provided

Additional context Minecraft Logs: https://mclo.gs/PhTfr7v

holybaechu commented 3 months ago

It looks like this only happens when hotkey is set to "Shift_L+F4"

flightlessmango commented 3 months ago

This is because Shift_L+F4 is assigned by default to reloading the config, you're reloading the config and starting/stopping a benchmark at the same time which is causing the crash. Now the crash is a bug that can be fixed, but you probably also didn't intend this behavior of doing two functions