search

flightlessmango / MangoHud

A Vulkan and OpenGL overlay for monitoring FPS, temperatures, CPU/GPU load and more. Discord: https://discordapp.com/invite/Gj5YmBb
MIT License
6.11k stars 263 forks source link

The new version 0.7.2 displays version 0.7.1 #1336

Closed minergenon closed 1 month ago

minergenon commented 1 month ago

The new version 0.7.2 displays version 0.7.1

flightlessmango commented 1 month ago

Do you mean in the hud? It looks fine on my end

AngryPenguinPL commented 1 month ago

Hi @flightlessmango I just downloaded archive with submodules and trying compile it for my distrubution but discovered that this source archive https://github.com/flightlessmango/MangoHud/releases/download/v0.7.2/MangoHud-v0.7.2-Source.tar.xz is named as 0.7.2 but after unpacking it point to 0.7.1. But not a big deal, just needed to remove %{version} macro from packaging system. Zrzut ekranu z 2024-05-26 20-24-01

flightlessmango commented 1 month ago

It's probably because it takes the project version which still is 0.7.1, but everything else should point towards it being 0.7.2. Don't know if this is worth a hotfix

kloczek commented 1 month ago

And https://github.com/flightlessmango/MangoHud/releases/download/v0.7.2/MangoHud-v0.7.2-Source.tar.xz dist tar ball has inside MangoHud-v0.7.1/ base directory.

flightlessmango commented 1 month ago

I understand that it's labeled incorrectly, but is it causing any issues downstream or something? If I just rename these and reupload them, is that sufficient for now?

flightlessmango commented 1 month ago

I've renamed it now, any other problem area?

flightlessmango commented 1 month ago

This should be resolved

hashworks commented 1 month ago

Looks like meson.build in MangoHud-v0.7.2-Source.tar.xz has version : 'v0.7.1'.

https://github.com/flightlessmango/MangoHud/blob/v0.7.2/meson.build#L3

flightlessmango commented 1 month ago

It does, but it should only be visible when running meson setup. Does it have any actual consequences downstream? I don't want to bump a hotfix for something that doesn't matter

hashworks commented 1 month ago

The ArchLinux package in extra uses that, which results in v0.7.1 for mangohud --version (and in the HUD I guess), but no other consequences than that.