search

flightphp / core

An extensible micro-framework for PHP
https://docs.flightphp.com
MIT License
2.6k stars 407 forks source link

ETag not wrapped in double quotes #431

Closed kuopassa closed 5 months ago

kuopassa commented 3 years ago

Flight::etag('test') creates a header that's not wrapped in double quotes, but this instructs ETag should do so.

n0nag0n commented 5 months ago

If it's standard, should be easy to add.

n0nag0n commented 5 months ago

Added it in with https://github.com/flightphp/core/commit/8d20c002c819df91b385ae3c3754b9466b2c786d

Also here's an MDN link https://developer.mozilla.org/en-US/docs/Web/HTTP/Headers/ETag