search

flightphp / core

An extensible micro-framework for PHP
https://docs.flightphp.com
MIT License
2.63k stars 409 forks source link

Removed all typehints to PHP <7.4 compatibility #527

Closed fadrian06 closed 8 months ago

fadrian06 commented 8 months ago

image image image

krmu commented 8 months ago

So many changes but seems like it'll get the job done. We do have a lot of unit tests in place that are all passing. What do you think @krmu ?

I will test it out.

fadrian06 commented 8 months ago

For a moment I was surprised when I changed the © haha... I know it's a massive change but it resolves inconsistencies in which some classes could work in <7.4 and others don't, so removing all the typehint not only maintains consistency but we also support php <7.4... We would have to test until which version works correctly, but I think in 7.0 it would work

n0nag0n commented 8 months ago

We are going to pass on this pull request and instead move forward with static typing on everything as it is stated that this project is 7.4 or greater. We are not going to support older versions of PHP.