Open fadrian06 opened 4 months ago
Ok to start the tests for php 8 are excluded from the main suite, I run the tests of that specific class by hand
Calling the app directly instead of __callStatic does make sense because it would help the static analyzer
I have several ideas to solve it but I don't know how difficult it is to implement it and keep everything working as is.
Extract shared functionalities into traits (it violates SOLID everywhere, although the Flight class does it but in an elegant way delegating everything to the Dispatcher, the Loader and the Engine)
It could be by extracting everything into a single trait that is automatically generated with an automated script, so with each docblock that is added, the static method will be created
PHP named arguments helps in some situations for cleaned code, it locks library maintainers to not change the argument names so easily without breaking changes, but php 8 must have support too...