fix: handle encoded slashes for url parameters - fixes #552

flightphp / core

An extensible micro-framework for PHP

https://docs.flightphp.com

MIT License

2.63k stars 409 forks source link

fix: handle encoded slashes for url parameters - fixes #552 #553

Closed daniel-sc closed 6 months ago

daniel-sc commented 6 months ago

Caveat: technically, this introduces a backwards incompatible change, for instances where in the request URL (regular) slashes are encoded. I'd guess, that this is not relevant in regular setups and even though this was gracefully handled before, this change is neccessary to assure path params can contain encoded slashes.

n0nag0n commented 6 months ago

I can take a look at it in hopefully tonight or tomorrow. Thanks for the contribution and for testing it :)

n0nag0n commented 6 months ago

I added some additional testing, but did get this merged in. Thanks so much! https://github.com/flightphp/core/commit/765887d388aff855cf4ffad8fef2df8ef3859025