Singapore Airlines Cargo instead of just Singapore Airlines

flightplan-tool / flightplan

Search for award inventory using Node.js and Headless Chrome!

Apache License 2.0

140 stars 41 forks source link

Singapore Airlines Cargo instead of just Singapore Airlines #35

Closed kirtan closed 5 years ago

kirtan commented 5 years ago

jd20 commented 5 years ago

Please provide a date / route that reproduces this, thanks!

kirtan commented 5 years ago

Sure thing! SIN-LHR 01/23/2019-2020

zubairv85 commented 5 years ago

This is a result of SQ having the same IATA code for their passenger airlines as well as their cargo airlines. When we lookup airline information, we do it based on the IATA code and since Singapore Airlines Cargo is listed after Singapore Airlines in src/data.js, the former is used instead of the latter. Lufthansa has the same issue.

Not sure how we can resolve this except to remove the duplicate IATA codes.

kirtan commented 5 years ago

no worries, just a small thing!