search

flightplan-tool / flightplan

Search for award inventory using Node.js and Headless Chrome!
Apache License 2.0
140 stars 41 forks source link

Add VS engine #54

Closed zubairv85 closed 4 years ago

zubairv85 commented 4 years ago

Added an engine for virgin atlantic award searches. Currently have the throttling speed set to slow because if found with fast searches the results page would show an error saying something like 'you have multiple browsers open'.

ilyakatz commented 4 years ago

@zubairv85 i see you closed this out, did it not work? do you remember what the problem was?

zubairv85 commented 4 years ago

@ilyakatz my PRs were open for a while so I just pushed them to a private fork instead and closed these PRs. With VS, however, they seem to be detecting the use of Chromium and preventing searches. Sometimes it would work but it was rare. I haven't used it for months so I never figured out a fix.

ilyakatz commented 4 years ago

ah gotcha, i'll check out your fork. i'm interested in playing around with some new engines so wanted to use your PRs as samples

On Mon, Jan 27, 2020 at 3:25 PM Zubair Valimohideen < notifications@github.com> wrote:

@ilyakatz https://github.com/ilyakatz my PRs were open for a while so I just pushed them to a private fork instead and closed these PRs. With VS, however, they seem to be detecting the use of Chromium and preventing searches. Sometimes it would work but it was rare. I haven't used it for months so I never figured out a fix.

— You are receiving this because you were mentioned. Reply to this email directly, view it on GitHub https://github.com/flightplan-tool/flightplan/pull/54?email_source=notifications&email_token=AACE7EUSLV5RPPVW3MQ3Y6DQ75UPHA5CNFSM4ICROGQKYY3PNVWWK3TUL52HS4DFVREXG43VMVBW63LNMVXHJKTDN5WW2ZLOORPWSZGOEKBOTBQ#issuecomment-579004806, or unsubscribe https://github.com/notifications/unsubscribe-auth/AACE7EQV4IWGVQIE4BUFQTDQ75UPHANCNFSM4ICROGQA .

-- Check out what I'm think about https://medium.com/perfectforloop