flightstats / hub

fault tolerant, highly available service for data storage and distribution
http://www.flightstats.com
MIT License
103 stars 35 forks source link

Don't persist webhook giveup reasons to the errors list #1027

Open Exide opened 6 years ago

Exide commented 6 years ago

Currently if a webhook gives up on an item for whatever reason (e.g. channel TTL, webhook TTL, max attempts reached) a message is added to the error array stored in Zookeeper for that webhook. I am thinking we should stop doing this and keep only actual errors in the array.

We can continue to log the reason normally at the debug level. Also, this information can still be inferred by the other pieces of information available (e.g. webhook settings, real errors in the array).