search

flightstats / hub

fault tolerant, highly available service for data storage and distribution
http://www.flightstats.com
MIT License
103 stars 35 forks source link

Dropwizard metrics #1127

Closed Paul-Hess closed 5 years ago

Paul-Hess commented 5 years ago

I thought I could just re-open this, but because I force pushed it force pushed me to open it as a new one, here is the link to the previous comments

https://github.com/flightstats/hub/pull/1118

lkemmerer commented 5 years ago

You've been really patient while we all work through naming and sorted out how we want to do DI for our new config patterns. I feel like this branch has kind of been the guinea pig for that. I think if you'd like to merge as-is, that's fine, or if you want to do /one-more/ round of changes, that's good, too.

Paul-Hess commented 5 years ago

the commits after https://github.com/flightstats/hub/pull/1127#commits-pushed-0b93fff are new and could use fresh review. They are easy to view commit by commit.

3a3f351 is the one that makes the most impact

lkemmerer commented 5 years ago

Might I suggest a squash + merge for this PR? 120 commits is a lot. :)