search

flightstats / hub

fault tolerant, highly available service for data storage and distribution
http://www.flightstats.com
MIT License
103 stars 35 forks source link

Removed unused imports, format and rearrange code using IntelliJ form… #1141

Closed manjula-chikkanagappa closed 5 years ago

manjula-chikkanagappa commented 5 years ago

…atter and update API doc

lkemmerer commented 5 years ago

Other than the documentation change (where there's a flightstats url, and removing the splatted imports, this looks good. I think the overridden methods vs the statics ordering thing rubbed me the wrong way because I almost always try to avoid having classes that have both types of methods and it was just weird to have to think about.

crozierm commented 5 years ago

Yes!

One thing... is this going to create merge conflicts with anything else that is in-flight? We definitely want to do this, but maybe we should get some other PRs through

manjula-chikkanagappa commented 5 years ago

Yes!

One thing... is this going to create merge conflicts with anything else that is in-flight? We definitely want to do this, but maybe we should get some other PRs through

Ok. Thanks. I will coordinate with Laurie and Paul on this one.