search

flightstats / hub

fault tolerant, highly available service for data storage and distribution
http://www.flightstats.com
MIT License
103 stars 35 forks source link

S3 write queue tests #1165

Closed Paul-Hess closed 5 years ago

Paul-Hess commented 5 years ago

I wanted to write some basic S3WriteQueue unit tests, particularly to document/test behavior that dropSomeWrites was previously in the code base to test. I got deeper in pulling at threads than I would have hoped so now I am putting it up for discussion before it goes deeper. Ultimately, I know that @manjula-chikkanagappa is working on config stuff that may supersede some of this refactoring and @dkleckler is working on integration refactoring around this as well. I'll be happy to wait for those PRs to go through first and merge whatever is left after some discussion and rebasing to those PRs.

dkleckler commented 5 years ago

Most of my changes are in *Bindings and ClusterContentService so far. This stuff shouldn't conflict with what I'm working on unless you try to decouple S3WQ from spoke. I'll merge it over to my branch once it hits master.