search

flightstats / hub

fault tolerant, highly available service for data storage and distribution
http://www.flightstats.com
MIT License
103 stars 35 forks source link

Fix issue #1171

Closed manjula-chikkanagappa closed 5 years ago

manjula-chikkanagappa commented 5 years ago

I have fixed SpokeTtlEnforcer service registration issues. We should clean up HubMain sometime. Its too cluttered and not comprehensible.

manjula-chikkanagappa commented 5 years ago

This looks good. I'd probably get rid of the mutable instance variable in the spoke ttl enforcer and non-finalize variables in methods but those things are stylistic/conventions that I follow that we haven't come to a consensus on.

The variables we are talking about in the SpokeTtlEnforcer class are are object scoped and I prefer initializing as instance variables. The variables are encapsulated in the class.