search

flightstats / hub

fault tolerant, highly available service for data storage and distribution
http://www.flightstats.com
MIT License
103 stars 35 forks source link

Remove circular dependency #1175

Closed manjula-chikkanagappa closed 5 years ago

manjula-chikkanagappa commented 5 years ago

1) Removed the circular dependency between ChannelService and ReplicationManager 2) TagWebhook and WebhookService are tightly coupled and could not break circular dependency. This requires some greater refactor and is out of scope of the ticket. I have used field injection for Tagwebhook field for now instead of constructor injection. 3) Merged Damon’s read only hub code changes 4) Cleaned up static injection through our hub. HubProvider.class is removed. 5) I have used Constants class as for constants used thought our hub. This approach is better than making fields public/package access within class. 6) Created Guice child injector for dependency injection to work in web socket resources.

lkemmerer commented 5 years ago

For a second I was surprised to see that there were 50k+ new lines of code, but it looks like there are a few really large test log output files that were inadvertently added to the PR.