search

flightstats / hub

fault tolerant, highly available service for data storage and distribution
http://www.flightstats.com
MIT License
103 stars 35 forks source link

fixes s3 stream not adding connection back to pool #1222

Closed Paul-Hess closed 5 years ago

Paul-Hess commented 5 years ago

PDXDDT-838

lkemmerer commented 5 years ago

I think I was seeing this warning when the hub received timeouts while it was processing stuff on the bulk endpoint, too....somewhere in ZipInputStream, I think, we're not using a try-with-resources where we might need to. That's probably a different ticket, though...

Paul-Hess commented 5 years ago

I think I was seeing this warning when the hub received timeouts while it was processing stuff on the bulk endpoint, too....somewhere in ZipInputStream, I think, we're not using a try-with-resources where we might need to. That's probably a different ticket, though...

~I remembered that I had come across those as I was searching for the culprit. I added a couple simple fixes for those to this as well~ I was wrong the ones I found pass the stream to a caller that closes the stream. Reverted.