search

flightstats / hub

fault tolerant, highly available service for data storage and distribution
http://www.flightstats.com
MIT License
103 stars 35 forks source link

Log level adjustments #1230

Closed lkemmerer closed 5 years ago

lkemmerer commented 5 years ago

I tried to break these up by changes between level (say info -> trace) in the attempt to make it easier to reason about each change. Not sure that's going to work, which is unfortunate because this is a big diff. :(

Tried to base the changes on the guidelines from here: https://confluence.flightglobal.io/display/DDT/Logging+Guidelines

lkemmerer commented 5 years ago

Most of the instances that look like they're missing an interpolation marker use a Throwable as the last argument. Slf4j figures that out and prints out the stacktrace without us having to add the marker. See https://www.slf4j.org/faq.html#paramException I think there are a few instances where I either need to make sure it's a throwable and not just the .getMessage() or add a {}. I'll review and fix them.

Paul-Hess commented 5 years ago

Oh my bad, I didn't know about that feature, cool, thanks.