search

flightstats / hub

fault tolerant, highly available service for data storage and distribution
http://www.flightstats.com
MIT License
103 stars 35 forks source link

Add prefix to s3 lifecycles rules crated by hub #1233

Closed manjula-chikkanagappa closed 5 years ago

manjula-chikkanagappa commented 5 years ago

Add prefix to s3 bucket lifecycle rules created by the HUB. This will help us to distinguish the s3 bucket lifecycle rules created externally (Outside HUB. From terraform code.)

manjula-chikkanagappa commented 5 years ago

Looks good to me. It's unfortunate that the tests around this behavior are obtuse ...and that the code's not structured in a way that'd make your change easy to test, but getting it testable will require a bit of work. How will the migration from non-prefixed configuration rules to prefixed ones work? It looks like this'd eventually roll everything over to the new naming convention, but we wouldn't be able to add any real non-hub rules until all the old stuff is phased out.

Yes. I have meeting set up with joe and rich to discuss migration strategies.