flightstats / hub

fault tolerant, highly available service for data storage and distribution
http://www.flightstats.com
MIT License
103 stars 35 forks source link

Clean up some webhook validation tests #1236

Closed lkemmerer closed 4 years ago

lkemmerer commented 4 years ago

I'm not sure why tests in this file were only intermittently failing, but I updated the test class to use lenient mocking, because otherwise the tests are sensitive to the order of validations. I couldn't think of a reason that ordering would be particularly important.

While I was in there, I standardized the way we set up the webhook under test. Now it'll build off a valid webhook and only override the fields with which we want to trigger the validation exception.