flightstats / hub

fault tolerant, highly available service for data storage and distribution
http://www.flightstats.com
MIT License
103 stars 35 forks source link

Reduce metric cardinality #1295

Closed lucasmo closed 2 years ago

lucasmo commented 2 years ago

Takes the monolithic hub.request metric and splits it into four different metrics:

I wasn't able to get tests running on my local workstation, so there aren't tests here 😦 That being said, this is a hard thing to test.

lkemmerer commented 2 years ago

I was getting started on refactoring the MetricsRequestFilter so that it's testable for the new behavior. Want me to take your branch and run with it?

lucasmo commented 2 years ago

I was getting started on refactoring the MetricsRequestFilter so that it's testable for the new behavior. Want me to take your branch and run with it?

@lkemmerer please do!

lucasmo commented 2 years ago

I'm also not set on these metric names or this quadchotomy.