flightstats / hub

fault tolerant, highly available service for data storage and distribution
http://www.flightstats.com
MIT License
103 stars 35 forks source link

Add tests/refactor request metrics reporting; drop internal channel channel tag #1301

Closed lkemmerer closed 2 years ago

lkemmerer commented 2 years ago

This refactors and adds tests. It also removes the channel tag from internal channel-related requests in an attempt to further minimize the number of custom metrics we have.

This temporarily has a log method in place rather than sending data to datadog, as my last dev deploy comically exploded our custom metrics count to something ridiculous and I don't want that to happen again. Once we get some eyes on this, I'll deploy it to a dev node and eyeball it before doing a full dev deploy. Commit-by-commit might be marginally easy. i don't know.