(Please pardon the messiness of the commits. I didn't think to tidy them up prior to creating the PR. I think the changes are simple enough that that might be ok.)
The story of this ticket goes something like:
Realize we're running ZK 3.4.11 rather than 3.5.9 (which is what we were running for the server).
Upgrade to 3.4.14 prior to bumping up to 3.5. This worked fine, though we (I) was doing some weird things with junit, so I updated and fixed those.
Update to 3.5.9. This broke some tests and it seemed to be due to the curator libraries we're using, where we were ignoring their ZK depenency.
Throw caution to the wind and update ZK all the way to 3.8 and the curator libraries up to their most recent versions, cutting out the special dependency management that was there. This, surprisingly, seems to be working with the 3.5.9 version of the ZK server.
Next steps before merging this in would be to update the server up to 3.8 on dev and see what happens. If there aren't any more code changes, I'll merge this and deploy it to staging. If there are necessary code changes, we'll need to downgrade the server back to 3.5.9 to ensure the changes are compatible. That way we can decouple code deploy from the server upgrade.
I've attached the gradle dependency diffs between master and this branch and then (maybe unhelpfully) added the more specific ZK/testing library diffs for [main/systemTests/tests.
(Please pardon the messiness of the commits. I didn't think to tidy them up prior to creating the PR. I think the changes are simple enough that that might be ok.)
The story of this ticket goes something like:
Next steps before merging this in would be to update the server up to 3.8 on dev and see what happens. If there aren't any more code changes, I'll merge this and deploy it to staging. If there are necessary code changes, we'll need to downgrade the server back to 3.5.9 to ensure the changes are compatible. That way we can decouple code deploy from the server upgrade.
I've attached the gradle dependency diffs between master and this branch and then (maybe unhelpfully) added the more specific ZK/testing library diffs for [main/systemTests/tests.
main-diff.txt systemTest-diff.txt test-diff.txt zk-dep-diff.txt