search

flightstats / node-insights

Submit data to New Relic Insights
7 stars 1 forks source link

custom logger could be passed #10

Closed wtfil closed 9 years ago

wtfil commented 9 years ago

Hi!

Thank you for awesome library, but I have only one issue: this library put something to stdout/stderr. Unfortunately it breaking our logging system:(

That's way I've made this PR. The main idea is to have ability to pass own logger which will fulfill product requirements.

Backward compatibility, of course, guaranteed

breedx2 commented 9 years ago

Looks fine to me, and my group can likely use this as well.

wtfil commented 9 years ago

@breedx2 good! Any plans about this PR?:)

mattpage commented 9 years ago

Yup, this is good stuff. Merged.

mattpage commented 9 years ago

@wtfil thanks for the new feature. I just published your change to version 1.08

wtfil commented 9 years ago

Thanks :)