search

flika-org / flika

An interactive image processing program for biologists written in Python.
http://flika-org.github.io/
MIT License
22 stars 1 forks source link

Update file_.py #59

Closed gddickinson closed 1 year ago

gddickinson commented 1 year ago

Replaced np.bool with builtin bool as np.bool deprecated since NumPy v1.2. This should fix file save error when FLIKA run on py v3.11

gddickinson commented 1 year ago

Hi Kyle - trying a pull request to master to fix a save error when using py v3.11. Let me know if I have done everything ok!

kyleellefsen commented 1 year ago

This looks good. Looks like there are 4 references in the code to np.bool. Want to replace them all in one go?

gddickinson commented 1 year ago

Great! Yes, I think it is safe to replace all 4 np.bool occurrences at once. We should probably also replace other deprecated numpy datatypes ( np.int etc). This is probably safest done on a case-by-case basis though...

On Mon, Oct 30, 2023 at 1:36 PM Kyle Ellefsen @.***> wrote:

This looks good. Looks like there are 4 references https://github.com/search?q=repo%3Aflika-org%2Fflika%20%22np.bool%22&type=code in the code to np.bool. Want to replace them all in one go?

— Reply to this email directly, view it on GitHub https://github.com/flika-org/flika/pull/59#issuecomment-1785824177, or unsubscribe https://github.com/notifications/unsubscribe-auth/ABY57Y6A76NLB2ZASPMWHKLYB7XTRAVCNFSM6AAAAAA6WO663WVHI2DSMVQWIX3LMV43OSLTON2WKQ3PNVWWK3TUHMYTOOBVHAZDIMJXG4 . You are receiving this because you authored the thread.Message ID: @.***>

gddickinson commented 1 year ago

All 4 np.bool replaced with bool

gddickinson commented 1 year ago

Hi Kyle,

When I try to install flika using pip I get the previous version when np.bool is used. Is there something I (or you) need to do to update this? It looked to me like the changes I had made were merged with the master... Not sure if pip definitions also need to be updated - or how to do this.

cheers, g

On Mon, Oct 30, 2023 at 2:00 PM George Dickinson @.***> wrote:

Great! Yes, I think it is safe to replace all 4 np.bool occurrences at once. We should probably also replace other deprecated numpy datatypes ( np.int etc). This is probably safest done on a case-by-case basis though...

On Mon, Oct 30, 2023 at 1:36 PM Kyle Ellefsen @.***> wrote:

This looks good. Looks like there are 4 references https://github.com/search?q=repo%3Aflika-org%2Fflika%20%22np.bool%22&type=code in the code to np.bool. Want to replace them all in one go?

— Reply to this email directly, view it on GitHub https://github.com/flika-org/flika/pull/59#issuecomment-1785824177, or unsubscribe https://github.com/notifications/unsubscribe-auth/ABY57Y6A76NLB2ZASPMWHKLYB7XTRAVCNFSM6AAAAAA6WO663WVHI2DSMVQWIX3LMV43OSLTON2WKQ3PNVWWK3TUHMYTOOBVHAZDIMJXG4 . You are receiving this because you authored the thread.Message ID: @.***>

kyleellefsen commented 1 year ago

There are two main ways to get flika onto a computer: using github or using pip. pip grabs the package from pypi.

When I make a change to flika that I'd like to put on pypi, I do the following:

Currently only Brett and I are collaborators for flika on pypi. If you make an account I can add you so you have upload privileges.

gddickinson commented 1 year ago

Got it! Thanks Kyle! I made a PyPi account and will look through the PyPI/Twine tutorials.

cheers, g

On Wed, Nov 1, 2023 at 11:42 AM Kyle Ellefsen @.***> wrote:

There are two main ways to get flika onto a computer: using github or using pip. pip grabs the package from pypi https://pypi.org/project/flika/.

When I make a change to flika that I'd like to put on pypi, I do the following:

Currently only Brett and I are collaborators https://pypi.org/manage/project/flika/collaboration/ for flika on pypi. If you make an account I can add you so you have upload privileges.

— Reply to this email directly, view it on GitHub https://github.com/flika-org/flika/pull/59#issuecomment-1789291891, or unsubscribe https://github.com/notifications/unsubscribe-auth/ABY57Y4L65GYNQHVFJRWXFLYCJ3YNAVCNFSM6AAAAAA6WO663WVHI2DSMVQWIX3LMV43OSLTON2WKQ3PNVWWK3TUHMYTOOBZGI4TCOBZGE . You are receiving this because you modified the open/close state.Message ID: @.***>