Open imunro opened 8 years ago
@seanwarren Do you want me to try and tackle this for 4.11? My feeling is that it's pretty minor so not worth the risk close to a release?
I think as you say best to let this one lie until the next release
While testing I just spotted that I have inadvertently replaced obj. with obj(comma) in two lines.
In fixing the above - I have noticed that the variable path in menu_file_load_widefield_callback & menu_file_load_tcspc_callback is not set. This hasn't been a problem before so presumably default_path is being changed.
@seanwarren I'm tempted to just delete the section: if strcmp(obj,default_path,obj.platform_default_path) obj.default_path = path; end
Can you think of any reason to veto ?
HI Ian - I'm actually tempted to always set the default path to the path used when loading data. I think this might save people quite a bit of time?
What do you think?
Certainly I can't see why not. default_platform_path is just for use when no data has yet been loaded which should only be an issue when users make errors. I suspect this chunk of code is intended to do something like that but somehow path doesn't get set.
I've postponed this to 4.11.3, in order to get 4.1.1.1 out, as what we have now has been fine for a long time. Then I suggest copying the OMERO-side functionality of having read and write path set to wherever data was last read from or written to. A file-side version of https://github.com/imperial-photonics/FLIMfit/blob/master/FLIMfitFrontEnd/Classes/%40OMERO_data_series/prompt_for_export.m would work well.
If file->save_data_settings is called before any data is loaded (see #200 ) then the popup window displays: "Save As" C/.xml". Looks as if the "/" is hardcoded somewhere. Not sure about the "C" at all.