search

flimfit / FLIMfit

State of the art fluorescence lifetime imaging analysis software
http://flimfit.org
GNU General Public License v2.0
23 stars 14 forks source link

Allow metadata extraction from filenames when using MD data #233

Closed seanwarren closed 8 years ago

seanwarren commented 8 years ago

Trigger build

imunro commented 8 years ago

I haven't had a chance to look at the code yet but one possible issue occurs: I use sort_nat on the selected files but with such complex file names there seems to be a danger of the extracted metadata being in the "wrong" order. I guess this just files under "sort your file names out" ?

seanwarren commented 8 years ago

Well I guess that is no more or less of an issue than it currently is. Ideally I think it would be good to be able to sort the displayed results based on the metadata rather than messing around with it at load time

imunro commented 8 years ago

Code looks good to me (especially where you got rid of that nasty switch). Only suggestion is that the add_class subroutine (last few lines of select_multiple) should be deleted now that it's no longer used. Otherwise happy to merge.

seanwarren commented 8 years ago

I've cleaned this up a little now as the loop was unnecessary - I hadn't quite clocked that only one dimension can be iterated over. I'm going to use this branch for a bit to test but I think we're good to merge

imunro commented 8 years ago

That looks much neater now. The GUI should ensure that > allowed can only be selected in one dimension. NB this work could be moved into extract_metadata if preferred.

seanwarren commented 8 years ago

OK cheers, I think this is ok for now