wrong input of IRF shift crashs FLIMfit

[Fredxxx]

Hey,

if your input for an IRF is "--1500" FLIMfit is crashing (see Error Report below). Would be nice if it just tell you the inout is wrong without crashing.

Error using griddedInterpolant
The coordinates of the input points must be finite values; Inf and NaN are not permitted.

Error in interp1

Error in flim_data_series/get_roi (line 398)

Error in flim_dll_interface/call_fitting_lib (line 56)

Error in flim_dll_interface/fit (line 185)

Error in flim_fit_controller/fit (line 83)

Error in flim_fit_controller/binned_fit_pushbutton_callback (line 271)

Error in flim_fit_controller>@(varargin)obj.binned_fit_pushbutton_callback(varargin{:}) (line 128)

Error in escaped_callback (line 7)

Error in flim_fit_controller>@(x,y)escaped_callback(x,y,@obj.binned_fit_pushbutton_callback) (line 128)

Best wishes Frederik

[seanwarren]

@fredxxx, where are you entering this value? Thanks

[Fredxxx]

Sorry I meant "IRF" -> "IRF shift" of "--1500". I am aware that two minuses do not make any sense but things like that happen accidentially and it would be nice if FLIMfit would not crash. Just remind you the inout is wrong or prohibits such an input.

[seanwarren]

Ok cool. Can I check if you get a 'hard' crash here or just an error message?

[Fredxxx]

It freezes and the error message above occurs. If I close the error message it is still frozen. So it is not really crashing, more freezing. Thanks

[seanwarren]

Ok cheers I'll add some error handing here pl

On Tue, May 31, 2016 at 5:18 AM -0700, "Fredxxx" notifications@github.com<mailto:notifications@github.com> wrote:

It freezes and the error message above occurs. If I close the error message it is still frozen. So it is not really crashing, more freezing. Thanks

— You are receiving this because you commented. Reply to this email directly, view it on GitHubhttps://github.com/imperial-photonics/FLIMfit/issues/235#issuecomment-222671524, or mute the threadhttps://github.com/notifications/unsubscribe/AB-HjzQWXwubL0bMo3VmVtu9ZR3pON3Eks5qHCb6gaJpZM4IqP7q.

NOTICE Please consider the environment before printing this email. This message and any attachments are intended for the addressee named and may contain legally privileged/confidential/copyright information. If you are not the intended recipient, you should not read, use, disclose, copy or distribute this communication. If you have received this message in error please notify us at once by return email and then delete both messages. We accept no liability for the distribution of viruses or similar in electronic communications. This notice should not be removed.

[imunro]

@seanwarren Sean I can probably look at that in the background while at the meeting if you want. Just let me know.

[imunro]

Solved by above commit

[seanwarren]

Nice one, cheers Ian

[imunro]

Not much time allowed to work on FLIMfit at the moment but I had a spare haff-hour.