flimfit / FLIMfit

State of the art fluorescence lifetime imaging analysis software
http://flimfit.org
GNU General Public License v2.0
23 stars 14 forks source link

Unable to load synthetic float ome-tiff (5.0.2 Pre-release Testing) #313

Closed imunro closed 7 years ago

imunro commented 7 years ago

I just tried loading a synthetic ome-tiff generated using the code attached. and got the following error! (see private e-mail from R.Laine) testOMETIFFGenerate.m.zip

Undefined function or variable 'float'. Error in flim_data_series/get_image_dimensions (line 63) Error in flim_data_series/load_multiple (line 30) Error in flim_data_series/load_single (line 104) Error in flim_data_series_controller/load_single (line 167) Error in front_end_menu_controller/menu_file_load_single_callback (line 654) Error in front_end_menu_controller>@(varargin)obj.menu_file_load_single_callback(varargin{:}) Error in escaped_callback (line 7) Error in front_end_menu_controller>@(x,y)escaped_callback(fcn) (line 261)

seanwarren commented 7 years ago

Cheers Ian, should be fixed by the latest commit

imunro commented 7 years ago

Now I get an error in load selected files at line 110 . obj.data_series_mem = zeros([mem_size' num_sel],obj.data_type);

where obj.data_type is 'float' & should I think be 'single' Matlab supports: Data Types: double | single | logical | int8 | int16 | int32 | int64 | uint8 | uint16 | uint32 | uint64

imunro commented 7 years ago

@seanwarren I just pushed this change. Can you check when you get a chance please. I'm not clear on why you include 'float' here. I get that you want to keep uint16 and uint32 in those formats but are you tring to keep 'double' as well?

https://github.com/flimfit/FLIMfit/blob/master/FLIMfitFrontEnd/Classes/%40flim_data_series/get_image_dimensions.m#L62

imunro commented 7 years ago

I just pushed a matching change to the OMERO side to keep uint16 & 32 as that.

imunro commented 7 years ago

@seanwarren I'm still slightly concerned by "float' in the line I link above. I can't find where this is caught (& presumably changed to 'single' anyway) before it creates the data.