search

flimfit / FLIMfit

State of the art fluorescence lifetime imaging analysis software
http://flimfit.org
GNU General Public License v2.0
23 stars 14 forks source link

Improved LaVision support #326

Closed seanwarren closed 7 years ago

seanwarren commented 7 years ago

Trigger build

imunro commented 7 years ago

I like the idea of pulling everything into a parseLaVision file but it seems to have gone missing from this PR ?

seanwarren commented 7 years ago

Apologies, seem to have added some random other file instead! Will commit tomorrow am

imunro commented 7 years ago

No problem.

imunro commented 7 years ago

Looks good generally - I would really like, however to retain the questdlg bit. https://github.com/flimfit/FLIMfit/blob/master/FLIMfitFrontEnd/Classes/%40flim_data_series/get_image_dimensions.m#L162-L167 otherwise I think there is a risk of confusion when users open non-FLIM ome-tiffs with FLIMfit & also I think it's a useful reminder to users that problems arise for LaVision's end not ours!

imunro commented 7 years ago

I pushed that now. Feel free to revert if you're unhappy. My guess is that checking the schema version is the fastest check we can do. The intention being to minimise the extent to which this LaVision stuff slows down loading valid ome-tiffs.

imunro commented 7 years ago

Should now be reverted to "tested" changes only and ready to merge. Let's decide on whether to use the "are you sure ?" LaVision prompt later. It's only one line after all. With this caveat this PR should address #324, #328 and #329.