Checks for InstrumentMode for LaVision files too rigorous!

[imunro]

Procter & Gamble Singapore Innovation Center in Singapore have sent a set of OME-TIFFS that they are unable to read. It appears that this test: https://github.com/flimfit/FLIMfit/blob/master/FLIMfitFrontEnd/InternalHelperFunctions/parse_lavision_ome_xml.m#L71-L72 is too rigorous and that the InstrumentMode is not always 'FLIM' as in the test. Relaxing this test to allow any instrumentMode fixes the issue. e.g. elseif (~isempty(dc_tcspc) && str2double(dc_tcspc.Value) == 1) || ... (~isempty(instrument_mode)) Unfortunately I can't seem to push this change for some reason @seanwarren could you have a look please.

[seanwarren]

Thanks for looking at this Ian. What error are you getting trying to push?

[imunro]

fatal: Authentication failed for 'https://github.com/flimfit/FLIMfit/' I suspect the problem is at my end I had to resurrect old accounts on old laptops. Do you think you could make the change above for me so the user can test?

[imunro]

@seanwarren Not to worry - finally worked out what was wrong and pushed the change,

[imunro]

@seanwarren Next question is the cI still running at all? Only Garvan-win-2 seemed to be online?

[imunro]

@seanwarren Can you tell me the current/future status of the CI please?

[seanwarren]

Hi Ian, sorry for the slow reply. I'm trying to figure something out here but it is becoming increasing difficult to find something stable!

[imunro]

Hi Sean. If we can't do this then we just have to let Proctor & Gamble know. They may be able to implement a work-around by setting the intrumentMode to 'FLIM' to match our test.

[seanwarren]

Hi Ian, I can get the windows one sorted quickly if that's enough? Or do they need the max version?

On Sun, 5 Jan 2020, 13:29 imunro, notifications@github.com wrote:

Hi Sean. If we can't do this then we just have to let Proctor & Gamble know. They may be able to implement a work-around.

— You are receiving this because you were mentioned. Reply to this email directly, view it on GitHub https://github.com/flimfit/FLIMfit/issues/360?email_source=notifications&email_token=AAPYPDYQH5AP3HJCTL2IKBTQ4HODDA5CNFSM4JX254N2YY3PNVWWK3TUL52HS4DFVREXG43VMVBW63LNMVXHJKTDN5WW2ZLOORPWSZGOEIDW7IY#issuecomment-570912675, or unsubscribe https://github.com/notifications/unsubscribe-auth/AAPYPD3S2BBVNJ34Z4R7Y7LQ4HODDANCNFSM4JX254NQ .

[imunro]

Thanks Sean I've asked. I'll let you know when I get an answer.

[imunro]

@seanwarren Windows! If it's easier to build locally then send it to them we can do that.

[seanwarren]

@imunro - there is a build here, let me know how you go: https://storage.cloud.google.com/flimfit-downloads/latest/FLIMfit%205.1.1-40-gcb3b55bf%20Setup%20x64.exe

[imunro]

Thanks Sean

[wang0760]

@imunro @seanwarren Hi, both, This is Yu from P&G and thank you very much for the kind support! I have a question regarding the Z-stack OME.Tiff files acquired. I can open it with some modification of the .xml mega data file. But I cannot get a life-time map data in the "Images or "Gallery". Is there a solution for that? Thank you very much!

[imunro]

Hi Yu @wang0760 You need to do a fit ,either pixel-by-pixel or globally as described at https://vimeo.com/210198672 did you do that ?