Internal error: '[string "PSUploadTask.lua"]:186: attempt to index local 'thumbSettings' (a boolean value)'

[Feilner]

I just converted to Synology Photos. As suggested I updated my Photo StatLr config, marked the pictures for republishing and let the 'CheckExistin' task run which went fine. But some Pictures where left in the state Republish.

So solve this I started the normal Uplaod task. Whre this error appeard.

20:25:31, INFO : PSInitPlugin:
        convert: 'C:\Program Files (x86)\Synology\Photo Station Uploader\ImageMagick\convert.exe'
        dcraw: 'C:\Program Files (x86)\Synology\Photo Station Uploader\ImageMagick\dcraw.exe'
        exiftool:   'C:/Windows/exiftool.exe'
        ffmpeg:     'C:\Program Files (x86)\Synology\Photo Station Uploader\ffmpeg\ffmpeg.exe'
20:25:31, INFO : PSInitPlugin: Successfully added 2 custom video export presets.
20:25:56, INFO : Environment: plugin: 7.2.1.20220516 Lr: 5.7.1 OS: Windows 8.1 Business Edition Lang: de
20:25:58, INFO : processRenderedPhotos starting
20:27:12, INFO : Login to Shared Space(http://synology/photo) OK
20:27:12, INFO : processRenderedPhotos(mode: Publish).
20:27:12, INFO : --------------------------------------------------------------------
20:27:12, INFO : exiftool Listener(""C:/Windows/exiftool.exe" -config "C:\Program Files\Adobe\Adobe Photoshop Lightroom 5.7.1\PhotoStation_upload.lrplugin\PSExiftool.conf" -stay_open True -@ "C:\Users\oliver\AppData\Local\Temp\ExiftoolCmds-676232832.88978.txt"  -common_args -charset filename=UTF8 -overwrite_original -fast2 -m > "C:\Users\oliver\AppData\Local\Temp\ExiftoolCmds-676232832.88978.log" 2> "C:\Users\oliver\AppData\Local\Temp\ExiftoolCmds-676232832.88978.error.log""): starting ...
20:27:15, ERROR: That does it, I'm leaving! Internal error: '[string "PSUploadTask.lua"]:186: attempt to index local 'thumbSettings' (a boolean value)'

I have now also tried with a new created album with the same result:

21:00:08, INFO : Environment: plugin: 7.2.1.20220516 Lr: 5.7.1 OS: Windows 8.1 Business Edition Lang: de
21:00:11, INFO : processRenderedPhotos starting
21:00:11, INFO : Login to Shared Space(http://synology/photo) OK
21:00:11, INFO : processRenderedPhotos(mode: Publish).
21:00:11, INFO : --------------------------------------------------------------------
21:03:52, ERROR: waitSemaphore('DSC00240.jpg'): 'PhotoServer' is blocked by 'DSC00240.jpg' since 300 sec! Please, restart Lr if it this is not going to end!
21:03:52, ERROR: Upload of 'M:\Hasenbilder\DSC00240.JPG' to 'Hasenbilder\DSC00240.jpg' failed!!!
21:03:52, ERROR: That does it, I'm leaving! Internal error: '[string "PSUploadTask.lua"]:186: attempt to index local 'thumbSettings' (a boolean value)'

I also just recognized that I have installed Synology Photos 1.2.0-0263 Within Photo StatLr I have selected the lastest version which is Photos 1.1

[flingo64]

The exception is caused by a bug when publishing photos with setting 'Generate thumbs' disabled. Either enable thumb generation or, if you really want to publish w/o thumbs, apply the following patch or wait for the next release.

In PSUploadTask.lua replace lines 185,186

        or not exportParams.photoServer:uploadPhotoFiles(dstDir, dstFilename, dstFileTimestamp, exportParams.thumbGenerate,
                                                renderedPhotoPath, title_Filename, thumbSettings.XL_Filename, thumbSettings.L_Filename, thumbSettings.B_Filename, thumbSettings.M_Filename, thumbSettings.S_Filename)

by

    or not exportParams.photoServer:uploadPhotoFiles(dstDir, dstFilename, dstFileTimestamp, exportParams.thumbGenerate,
                                                renderedPhotoPath, title_Filename,
                                                thumbSettings and thumbSettings.XL_Filename,
                                                thumbSettings and thumbSettings.L_Filename,
                                                thumbSettings and thumbSettings.B_Filename,
                                                thumbSettings and thumbSettings.M_Filename,
                                                thumbSettings and thumbSettings.S_Filename)

Thanks for reporting and thanks for pointing me to Photos 1.2!

[flingo64]

Version 7.2.2 solves the issue and is now released.

[Feilner]

Thanks for the fast analysis and fix! I can confirm that the upload is working fine now.