Closed dangshazi closed 2 years ago
Thanks for opening this PR, I will take a look soon.
@dangshazi BTW, we updated the license header today because we were informed that project which is still not contributed to apache can not use the apache license header. As a result, you also need to update that.
@dangshazi I am a prometheus expert, so there may be something I can't figure out. Have you fully test this feature?
, so there may be something I can't figure
I'll add more test
@dangshazi Thanks for the contribution. Merged.
What is the purpose of the change
Support reporting metrics to prometheus
Brief change log
Verifying this change
Add Tests:
com.alibaba.flink.shuffle.metrics.reporter.PrometheusReporterTest
ConfigurationParserUtilsTest
This change is already covered by existing tests, such as
com.alibaba.flink.shuffle.metrics.reporter.ReporterSetupTest