search

flink-extended / flink-remote-shuffle

Remote Shuffle Service for Flink
Apache License 2.0
191 stars 56 forks source link

[FRS-16]Support reporting metrics to prometheus #64

Closed dangshazi closed 2 years ago

dangshazi commented 2 years ago

What is the purpose of the change

Support reporting metrics to prometheus

Brief change log

Verifying this change

Add Tests:

This change is already covered by existing tests, such as com.alibaba.flink.shuffle.metrics.reporter.ReporterSetupTest

wsry commented 2 years ago

Thanks for opening this PR, I will take a look soon.

wsry commented 2 years ago

@dangshazi BTW, we updated the license header today because we were informed that project which is still not contributed to apache can not use the apache license header. As a result, you also need to update that.

wsry commented 2 years ago

@dangshazi I am a prometheus expert, so there may be something I can't figure out. Have you fully test this feature?

dangshazi commented 2 years ago

, so there may be something I can't figure

I'll add more test

wsry commented 2 years ago

@dangshazi Thanks for the contribution. Merged.