[FLINK-11421] again - Githubissues

flinkqa commented 5 years ago

Thanks a lot for your contribution to the Apache Flink project. I'm the @flinkqa. I help the community to review your pull request. We will use this comment to track the progress of the review.

Automated Checks

Last check on commit 81aa2f21d34ce689e458ff1fed6de784f24770d3 (Fri Aug 02 16:40:01 CEST 2019)

Warnings:

Documentation files were touched, but no .zh.md files: Update Chinese documentation or file Jira ticket.

Review Progress

✅ 1. The [description] looks good.
- Approved by @rmetzger [committer]
✅ 2. There is [consensus] that the contribution should go into to Flink.
- Approved by @rmetzger [committer]
❗ 3. Needs [attention] from.
- Needs attention by @flinkqa, @rmetzger [committer], @stratosphere-javadocs
✅ 4. The change fits into the overall [architecture].
- Approved by @rmetzger [committer]
✅ 5. Overall code [quality] is good.
- Approved by @rmetzger [committer]

Please see the Pull Request Review Guide for a full explanation of the review process.

The Bot is tracking the review progress through labels. Labels are applied according to the order of the review items. For consensus, approval by a Flink committer of PMC member is required

Bot commands

The @flinkqa bot supports the following commands:

@flinkqa approve description to approve one or more aspects (aspects: description, consensus, architecture and quality)
@flinkqa approve all to approve all aspects
@flinkqa approve-until architecture to approve everything until architecture
@flinkqa attention @username1 [@username2 ..] to require somebody's attention
@flinkqa disapprove architecture to remove an approval you gave earlier