Thanks a lot for your contribution to the Apache Flink project. I'm the @flinkqa. I help the community
to review your pull request. We will use this comment to track the progress of the review.
Automated Checks
Last check on commit f0a04c5a7694333d7506d5e15c42412d0b98b389 (Tue Aug 06 17:27:51 CEST 2019)
Warnings:
Documentation files were touched, but no .zh.md files: Update Chinese documentation or file Jira ticket.
This pull request references an unassigned Jira ticket. According to the code contribution guide, tickets need to be assigned before starting with the implementation work.
Mention the bot in a comment to re-run the automated checks.
Review Progress
❓ 1. The [description] looks good.
❓ 2. There is [consensus] that the contribution should go into to Flink.
❓ 3. Needs [attention] from.
❓ 4. The change fits into the overall [architecture].
❓ 5. Overall code [quality] is good.
Please see the Pull Request Review Guide for a full explanation of the review process.
The Bot is tracking the review progress through labels. Labels are applied according to the order of the review items. For consensus, approval by a Flink committer of PMC member is required Bot commands
The @flinkqa bot supports the following commands:
@flinkqa approve description to approve one or more aspects (aspects: description, consensus, architecture and quality)
@flinkqa approve all to approve all aspects
@flinkqa approve-until architecture to approve everything until architecture
@flinkqa attention @username1 [@username2 ..] to require somebody's attention
@flinkqa disapprove architecture to remove an approval you gave earlier
rmetzger
commented
4 years ago
Thanks a lot for your contribution to the Apache Flink project. I'm the @flinkqa. I help the community to review your pull request. We will use this comment to track the progress of the review.
Automated Checks
Last check on commit f0a04c5a7694333d7506d5e15c42412d0b98b389 (Tue Aug 06 17:27:51 CEST 2019)
Warnings:
.zh.mdfiles: Update Chinese documentation or file Jira ticket.Mention the bot in a comment to re-run the automated checks.
Review Progress
Please see the Pull Request Review Guide for a full explanation of the review process.
The Bot is tracking the review progress through labels. Labels are applied according to the order of the review items. For consensus, approval by a Flink committer of PMC member is required
Bot commands
The @flinkqa bot supports the following commands:@flinkqa approve descriptionto approve one or more aspects (aspects:description,consensus,architectureandquality)@flinkqa approve allto approve all aspects@flinkqa approve-until architectureto approve everything untilarchitecture@flinkqa attention @username1 [@username2 ..]to require somebody's attention@flinkqa disapprove architectureto remove an approval you gave earlier