search

flintlib / arb

Arb has been merged into FLINT -- use https://github.com/flintlib/flint/ instead
http://arblib.org/
GNU Lesser General Public License v2.1
457 stars 137 forks source link

The function n_gcd_full isn't there anymore in flint 2.9.0 beta1 #420

Closed SnarkBoojum closed 4 months ago

SnarkBoojum commented 2 years ago

In flint 2.6.0, n_gcd_full was deprecated and is now removed.

You just need to s/n_gcd_full/n_gcd/ in acb_modular/hilbert_class_poly.c and arb_fmpz_poly/gauss_period_minpoly.c to get rid of the problem.

fredrik-johansson commented 2 years ago

This is already fixed in master. There will be a new Arb release shortly following the new Flint.

SnarkBoojum commented 2 years ago

If it's possible to have a good arb before the next flint, that's better.

You're too focused on sagemath where each new version will change flint+arb in a single stroke : all other distributions will go with the flow: see the new flint, package it, see it breaks arb, report here...

fredrik-johansson commented 2 years ago

We should maybe put back n_gcd_full in Flint until 2.10 just so that there are minimal issues.

albinahlback commented 2 years ago

Or perphaps it shouldn't compile if you have a lower version?