search

flintlib / arb

Arb has been merged into FLINT -- use https://github.com/flintlib/flint/ instead
http://arblib.org/
GNU Lesser General Public License v2.1
455 stars 137 forks source link

add more acb-related 'set' and 'contains' convenience functions #63

Open argriffing opened 8 years ago

argriffing commented 8 years ago

Currently there's a function called acb_set_fmpz_fmpz that sets the real part and the imaginary part of a complex ball to the provided integers. There are also functions like acb_contains_fmpz.

Here are some similarly named but hypothetical functions that I'd like: acb_contains_fmpz_fmpz acb_set_fmpq_fmpq acb_contains_fmpq_fmpq acb_mat_set_fmpq_mat_fmpq_mat acb_mat_contains_fmpq_mat_fmpq_mat

Any opinions on this idea? Right now I think the acb_mat/test/t-mul.c test doesn't actually involve any numbers with nonzero imaginary parts. My motivation for posting this issue was that when I looked at improving the coverage of that test I started to want more convenience functions.

argriffing commented 8 years ago

Here's a PR with the tests https://github.com/fredrik-johansson/arb/pull/64. I've decided to just put the convenience functions in the test file. Maybe there does not need to be a combinatorial explosion of manually written convenience functions for all combinations of types.

fredrik-johansson commented 8 years ago

Those functions seem fine to me.

rickyefarr commented 8 years ago

Were these functions ever added?